Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Very interesting, but one thing Re: AngularJS

> dependency injection minification headaches

Meh, that's hand-wavy at best. The only thing you have to do to pass minification is to include the injected dependencies in an array like so:

    ['$stateProvider', '$urlRouterProvider',
    function ($stateProvider, $urlRouterProvider) {
        // Stuff
    }]
You get used to it in seconds and then it's not really an issue anymore.


I'm currently using this style in a RequireJS/Angular project. Everything works great, but it's pretty ugly. We should strive to not write ugly shit, but good clean expressive code. This is so non-standard it hurts. There are plenty of other ways the Angular team could have gone; CommonJS or AMD would have been better choices IMO.


Use ngmin, it converts into the ugly style. https://github.com/btford/ngmin

There's also a grunt plugin. https://github.com/btford/grunt-ngmin


ngmin doesn't work with r.js. My response was about using it with AMD modules. I know there were a few efforts to get ngmin/r.js working together, but last time I searched around I didn't see anything promising.


I wonder how much work it would be to actually integrate DI/module system and RequireJS.


personally, I already have a massive library of AMD modules, using a second module system, even if it adds a feature is confusing for people who join the project and makes for ugly code.

Also I don't like having to organize unrelated code into factories and services just because that's how Angular wants to view the world.


Or if you're already in the process of minification you can also fix these injections automatically, with a simple regex or https://github.com/btford/ngmin.


There is also this direct integration for IntelliJ/WebStorm/PHPStorm: http://www.youtube.com/watch?v=ZvWftlp7TKY




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: