Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

As a reviewer I've seen numerous examples of PRs that were basically out of sync with the rest of the project, did not solve the problem they were supposed to solve, or added buggy or unmaintainable code.

Arguments like "but it works in majority of cases" are a way to delegate fixing issues to somebody else later. Unless noone will be using that code at all, in which case it should not be merged either.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: