Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

You are quoting Jia Tan [1]. The malicious actor wrote that comment when deliberately breaking the check in the first place.

Fixing headers or extra tests would not have prevented this, as there is no indication the headers were broken in the first place, and extra tests could have been compromised (or ignored for release tarball) some other way.

[1] https://git.tukaani.org/?p=xz.git;a=commit;h=328c52da8a2bbb8...



Should the better fix then to have been to revert the bad commit with the malicious commit message, rather than just deleting the dot (as was done)?


The better fix would be to move to proper dependency management and depend on a version range of a dependency instead of hoping you can do a better job of modelling the same with strings hardcoded into a CMakeLists.txt.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: