Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

[flagged]


I think you're missing the point of what the author is asking. Showing the email address from the commit is one thing (and the author is fine with showing that). That's the limit to what git gives you. Associating that email address to a GitHub user profile which never verified ownership of that email address is a GitHub UX decision, having nothing to do with git. That's what the author is saying is a security flaw.

That said, clearly users shouldn't be ascribing any level of certainty to commits that point to a GitHub profile even if the email address is verified, since AFAIK nothing is stopping the inverse attack, i.e. having someone else take credit for your work. Which is arguably more exploitable.


That's not the main complain, the issue is that GitHub is allowing users to claim emails even without verifying users are the owners of those emails.


how are they claiming emails?


> The problem is that GitHub makes this association even for unverified email addresses. In this case of course it really was Linus who made the first commit, but all it took was someone to add Linus's email address to their GitHub profile - without any verification - and now GitHub displays this person as the author instead.


I can also write on my own web site that my email address is [email protected]. But I can't send or receive messages from it, so how exactly would I be claiming it?

Does GitHub allow you to impersonate Linus via email? No, it does not.


I think you're fixated on the inverse of what this is. Imagine it's a true commit by Linus identified by his email address. This issue is when someone creates a GitHub profile with Linus' email address and by doing so, causes the GitHub UI to ascribe authorship of that commit to your user profile via your GitHub username and a link to your profile.


Also there's no need to imagine because that's what this is. A real commit with a correct email showing the wrong user.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: