Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

No, it really depends. It's easy to overlook stuff on a merge request. I'd interview both of the reviewers, and with them look at the actual MR and see what they were looking at, and ask them how they missed this and why they thought it was OK to merge.

I've seen some pretty glaring stuff get through a review process, particularly with junior engineers.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: