Are they? They are just making it really hard as far as I can tell. I haven't seen any lawsuits for repairing a device nor any laws that would prevent it. Of course right now the law allows companies to disallow you from importing counterfeit (as in "not sold by Apple") parts - maybe that's the issue we should focus on?
While I agree with the general intent of it, to call it "right to repair" legislation is slightly misleading. Apple isn't trying to make it so that if you open your own device you'll go to jail or something like that. When you buy an iPhone, you can do whatever the hell you want with it. Apple doesn't care. What it IS trying to do is basically not making it so that it actively helps people to repair the device. Right to repair legislation — as in the case of New York's — would require companies to take certain actions, like providing repair manuals and parts.
Apple is trying to take away everyone's legal right to repair property that they own. I consider that a violation i of property rights.