There's a really good code review guide on the plaid blog that addressed this: h... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

		hyperpape on Aug 15, 2018 \| parent \| context \| favorite \| on: Code review review is the manager’s job There's a really good code review guide on the plaid blog that addressed this: https://blog.plaid.com/building-an-inclusive-code-review-cul.... Money quote: "Nothing should be surprising to a reviewer in a code review: discuss any significant design decisions before code is written. Code reviews are a time to iron out implementation details, not discuss major design or architecture decisions."

lox on Aug 15, 2018 [–]

What if you use pull requests to prototype architectural change? My take is your pull request should include the context of the change and the sort of feedback you want.

hyperpape on Aug 15, 2018 | [–]

I think that explicitly noting “this isn’t ready, but I’d like to discuss x,y,z” ought to cover it.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact